-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new config
hook
#1577
Add new config
hook
#1577
Conversation
Signed-off-by: Benjamin Somers <[email protected]>
And obviously I forgot to fix the tests :) |
1159c52
to
1a431a4
Compare
Phew that linter is very conservative! |
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
1a431a4
to
a85a512
Compare
Looks good and was pretty easy to review thanks to how the commits were split. Only nit is around those marshal/unmarshal and temporary config type in the |
It’s not, but the values
|
Yeah, 3rd is fine with me. |
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
Signed-off-by: Benjamin Somers <[email protected]>
a85a512
to
be7d5f3
Compare
Closes #1400